Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump pip minimum version to >= 23.0 #1971

Closed
wants to merge 2 commits into from
Closed

Bump pip minimum version to >= 23.0 #1971

wants to merge 2 commits into from

Conversation

apljungquist
Copy link
Contributor

Contributor checklist
  • Included tests for the changes.
  • PR title is short, clear, and ready to be included in the user-facing changelog.
Maintainer checklist
  • Verified one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@apljungquist
Remove py37 from tox.ini
d243b90 
... so that running `tox` locally at least has a chance of succeeding.
@apljungquist
Increase minimum pip version to 23
edc0b0d 
... so that we can pip's vendored pyproject_hooks.
@apljungquist apljungquist mentioned this pull request Aug 20, 2023
Merged
4 tasks
@atugushev atugushev added the dependency Related to a dependency label Aug 20, 2023
atugushev
atugushev reviewed Aug 20, 2023
View reviewed changes
pyproject.toml
@@ -38,7 +38,7 @@ dependencies = [
# direct dependencies
"build",
"click >= 8",
"pip >= 22.2",
"pip >= 23",
Copy link
Member

@atugushev atugushev Aug 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"pip >= 23",
"pip >= 23.1",

Usually, when bumping pip version we keep supporting only the two most recent minor versions (undocumented policy discussed in #926). Therefore we can bump the pip up to the 23.1 version.

Could you please also grep all PIP_VERSION mentions and check for any obsolete branches?

@atugushev
Copy link
Member

I'll close this based on the #1681 (comment). Nonetheless, thanks for the PR @apljungquist.

@atugushev atugushev closed this Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atugushev atugushev atugushev left review comments

Assignees
No one assigned
Labels
dependency Related to a dependency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apljungquist @atugushev